Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geofencing: Add SUBSCRIPTION_DELETED as termination-reason #242

Conversation

maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Adds a new termination-reason for "subscription-ends" - CloudEvent, when the user deletes the subscriptions via
DELETE /subscriptions/{subscriptionId}

Which issue(s) this PR fixes:

Fixes #141

@maxl2287 maxl2287 added enhancement New feature or request Fall24 Meta-release Fall24 labels Jul 29, 2024
@maxl2287 maxl2287 self-assigned this Jul 29, 2024
@maxl2287 maxl2287 changed the title Add SUBSCRIPTION_DELETED as termination-reason geofencing: Add SUBSCRIPTION_DELETED as termination-reason Jul 29, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit ee4208a into camaraproject:main Jul 30, 2024
1 check passed
@maxl2287 maxl2287 deleted the feature/add-subscription-deleted-termination-reason branch July 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fall24 Meta-release Fall24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geofencing - Adding SUBSCRIPTION_DELETED as a Termination Reason
2 participants